Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update angular starter to v17 #21

Merged
merged 1 commit into from
Nov 9, 2023
Merged

update angular starter to v17 #21

merged 1 commit into from
Nov 9, 2023

Conversation

JeanMeche
Copy link
Contributor

@JeanMeche JeanMeche commented Sep 29, 2023

This allows to enable the new @-synthax* renaming my-app to app-root to match what the CLI creates

  • replacing zone.js/dist/zone because of the 0.14.0 breaking changes
  • setup the application builder

@JeanMeche JeanMeche marked this pull request as ready for review September 29, 2023 15:07
@fvsch
Copy link
Contributor

fvsch commented Sep 29, 2023

Hi @JeanMeche,

I would wait for the Angular 17 release. We currently have only one Angular starter template, so we want that to use a stable release.

We can maybe treat this PR as a draft, update it for the Angular 17 stable release, and merge it then?

What do you think @sulco?

@JeanMeche
Copy link
Contributor Author

Just for the information, the next release is expected for the 2nd week of november.

angular/tsconfig.json Outdated Show resolved Hide resolved
@JeanMeche JeanMeche changed the title update angular starter to 17.next update angular starter to v17 Nov 9, 2023
@JeanMeche
Copy link
Contributor Author

Hi now that v17 has been released, I've updated the starter with the latest stable version !

* renaming `my-app` to `app-root` to match what the CLI creates
* replacing `zone.js/dist/zone` because of the 0.14.0 breaking changes
* setup the application builder
* link to ADEV instead of AIO
@sulco sulco merged commit c1038dd into stackblitz:main Nov 9, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants